Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty tests in testing farm result #388

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@dhodovsk
Copy link
Contributor

dhodovsk commented Feb 10, 2020

The use should stay fine even with empty list: https://github.com/packit-service/packit-service/blob/master/packit_service/worker/testing_farm_handlers.py#L80

The log message will be:

Received testing-farm test results:
[]

Let me know if you want to change that.

@dhodovsk

This comment has been minimized.

Copy link
Contributor Author

dhodovsk commented Feb 10, 2020

Fixes #387

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 10, 2020

Build failed.

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Feb 10, 2020

recheck

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 10, 2020

Build failed.

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Feb 10, 2020

recheck

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Feb 10, 2020

Hm, the openshift cluster no longer starts:

E0210 11:44:27.873566   22593 run_self_hosted.go:571] API server error: Get https://127.0.0.1:8443/healthz?timeout=32s: dial tcp 127.0.0.1:8443: connect: connection refused ()
Error: timed out waiting for the condition
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 10, 2020

Build failed.

@dhodovsk dhodovsk added the mergeit label Feb 11, 2020
@dhodovsk dhodovsk force-pushed the dhodovsk:event-tests-empty branch from e3d6f2f to 08094e9 Feb 12, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 12, 2020

Build failed.

Copy link
Member

lachmanfrantisek left a comment

Merging. I'll add tests for it myself in my PR (#391)

@lachmanfrantisek lachmanfrantisek merged commit 98d34c0 into packit-service:master Feb 12, 2020
2 of 3 checks passed
2 of 3 checks passed
local/check check status: failure
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
@dhodovsk dhodovsk linked an issue that may be closed by this pull request Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.