Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build logs view + data in psql #406

Merged

Conversation

@TomasTomecek
Copy link
Contributor

TomasTomecek commented Feb 14, 2020

replaces #257 #297

Fixes #1
Fixes #264

  • tests pass in CI
    • utilize pg and redis deployed w/ requre tests
  • have a succ build on stg w/ good logs
  • move PR comments to logs (new PR)
  • SRPM check has logs
Base = declarative_base()


class GitHubProject(Base):

This comment has been minimized.

Copy link
@TomasTomecek

TomasTomecek Feb 14, 2020

Author Contributor

This is the PSQL schema.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build succeeded.

@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

TomasTomecek commented Feb 14, 2020

Build succeeded.

* [packit-service-pre-commit ](https://softwarefactory-project.io/zuul/t/local/build/c6814080d8b94080a6cbb650b87f3f0d) : SUCCESS in 3m 14s

* [packit-service-tests ](https://softwarefactory-project.io/zuul/t/local/build/dcd2c446e13e4ca981b8d794173db51c) : SUCCESS in 13m 43s

* [packit-service-tests-requre ](https://softwarefactory-project.io/zuul/t/local/build/f381a7b3e9fb4656bfcedb52fcfd5ad2) : SUCCESS in 15m 35s

WHAT?! that's not possible

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 0c61e45 to 4b30db8 Feb 14, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build failed.

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 4b30db8 to 37a7689 Feb 14, 2020
Copy link
Member

jpopelka left a comment

respect

files/install-deps-worker.yaml Outdated Show resolved Hide resolved
@TomasTomecek TomasTomecek changed the title build logs view + data in psql wip: build logs view + data in psql Feb 14, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build succeeded.

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 37a7689 to 661f466 Feb 14, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build succeeded.

@csomh
csomh approved these changes Feb 17, 2020
Copy link
Member

csomh left a comment

I have a few borderline nitpicking comments, but other than that this looks great! 🚀

Good to be merged once you are happy with testing.

alembic/env.py Outdated Show resolved Hide resolved
packit_service/service/urls.py Outdated Show resolved Hide resolved
packit_service/models.py Outdated Show resolved Hide resolved
@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 661f466 to 328fe39 Feb 17, 2020
@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

TomasTomecek commented Feb 17, 2020

thanks for the comments, pushed changes to address them, also realised the schema is not applied, hence the sentry issue https://sentry.io/organizations/red-hat-0p/issues/1518475677/

built && pushed new stg image, let's see tomorrow

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 17, 2020

Build succeeded.

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 328fe39 to 608baf6 Feb 18, 2020
@TomasTomecek TomasTomecek changed the title wip: build logs view + data in psql build logs view + data in psql Feb 18, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 18, 2020

Build failed.

@csomh

This comment has been minimized.

Copy link
Member

csomh commented Feb 19, 2020

Tests fail because

Unable to find '../secrets/dev/dashboard-privkey.pem' in expected

@sakalosj I think the tests should be updated to set up dashboard-privkey.pem after the recent deployment changes.

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 608baf6 to 9c19041 Feb 19, 2020
@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

TomasTomecek commented Feb 19, 2020

Tests fail because

Unable to find '../secrets/dev/dashboard-privkey.pem' in expected

@sakalosj I think the tests should be updated to set up dashboard-privkey.pem after the recent deployment changes.

shoiuld be fixed in 2842c46

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build failed.

@sakalosj

This comment has been minimized.

Copy link
Contributor

sakalosj commented Feb 19, 2020

Tests fail because

Unable to find '../secrets/dev/dashboard-privkey.pem' in expected

@sakalosj I think the tests should be updated to set up dashboard-privkey.pem after the recent deployment changes.

shoiuld be fixed in 2842c46

thanks - wasnt aware of this

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 9c19041 to 149663d Feb 19, 2020
@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

TomasTomecek commented Feb 19, 2020

#414 to fix CI

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build failed.

@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

TomasTomecek commented Feb 19, 2020

recheck

since the whole service is deployed

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
we have it deployed already as part of p-s

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build failed.

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 149663d to 4cd1365 Feb 19, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build succeeded.

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 4cd1365 to c43a7df Feb 19, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build succeeded.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build succeeded.

* store SRPM logs in a dedicated table

* build logs: utilize our IDs instead of COPR build IDs

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek TomasTomecek force-pushed the TomasTomecek:logs2 branch from 0c5da88 to 0a14ddf Feb 20, 2020
@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

TomasTomecek commented Feb 20, 2020

Finally a successful build, merging packit-service/hello-world#78

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 20, 2020

Build succeeded.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 20, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b95a4a7 into packit-service:master Feb 20, 2020
4 checks passed
4 checks passed
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
@TomasTomecek TomasTomecek deleted the TomasTomecek:logs2 branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.