Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about who can trigger PaaS #445

Merged
merged 1 commit into from Mar 2, 2020

Conversation

@csomh
Copy link
Member

csomh commented Mar 2, 2020

"collaborators" was not an exact definition for who can trigger
Packit-as-a-Service. Make sure the error message is explicit about the
GitHub permissions required.

Partially fixes #442.

Signed-off-by: Hunor Csomortáni csomh@redhat.com

"collaborators" was not an exact definition for who can trigger
Packit-as-a-Service. Make sure the error message is explicit about the
GitHub permissions required.

Partially fixes #442.

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
@csomh csomh requested a review from lachmanfrantisek Mar 2, 2020
@@ -380,7 +383,10 @@ def __init__(self, config: ServiceConfig, event: PullRequestCommentEvent):
def run(self) -> HandlerResults:
collaborators = self.project.who_can_merge_pr()
if self.event.github_login not in collaborators | self.config.admins:
msg = "Only collaborators can trigger Packit-as-a-Service"
msg = (
"Only users with write or admin permissions to the repository "

This comment has been minimized.

Copy link
@lachmanfrantisek

lachmanfrantisek Mar 2, 2020

Member

I am only a little confused about the write permissions meaning. (Since in the comments, you can see terms like member, collaborator, ...)

This comment has been minimized.

Copy link
@csomh

csomh Mar 2, 2020

Author Member

If I understand it correctly than member and collaborator are org membership terms (roles?), but we check for repository permission levels.

(Yes, this part of GitHub is very confusing.)

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 2, 2020

Build succeeded.

Copy link
Member

lachmanfrantisek left a comment

Thanks for making it clear!

@csomh csomh merged commit d1c2be3 into packit-service:master Mar 2, 2020
4 checks passed
4 checks passed
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
ci/dockercloud (/Dockerfile.worker) Your tests passed in Docker Cloud
Details
local/check check status: success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.