Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework mapping #476

Merged
merged 3 commits into from Mar 11, 2020
Merged

Rework mapping #476

merged 3 commits into from Mar 11, 2020

Conversation

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Mar 10, 2020

  • Make the mapping of handlers to events work and easier to use.
    • Testing farm results and Copr events are handled as other events.
    • Mapping support multiple triggers for one job and get's a correct config part.
  • Fixes: #465

TODO:

  • More tests (more combinations of triggers and configs).
  • Check the commenting.
  • Add docs for the decorators.
  • Remove internal job type (e.g. copr_end) from the JobType enum in packit. (After this PR, it can contain only the config-relevant values.)
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:mapping branch from a134fe2 to fbcdf0c Mar 10, 2020
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 10, 2020

Build succeeded.

@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:mapping branch from fbcdf0c to 15bc5c7 Mar 10, 2020
@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Mar 10, 2020

The commenting part is still WIP -- I need to check/fix all the tests since I've changed the handling of the comment events. (Now, they should be handled in the same way as other events.)

edit: I've reverted that part, it will take some time to make it work.

@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:mapping branch from 15bc5c7 to 40021fd Mar 10, 2020
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 10, 2020

Build failed.

@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:mapping branch from 40021fd to eca6999 Mar 11, 2020
@lachmanfrantisek lachmanfrantisek changed the title WIP: rework mapping Rework mapping Mar 11, 2020
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build succeeded.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:mapping branch from eca6999 to 1c00dba Mar 11, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build succeeded.

Copy link
Contributor

TomasTomecek left a comment

wow, very nice! let's try this on stg

Copy link
Member

jpopelka left a comment

advanced magic level those mappings are :-)

packit_service/worker/jobs.py Show resolved Hide resolved
packit_service/worker/handlers/abstract.py Outdated Show resolved Hide resolved
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:mapping branch from d00ef70 to e614b6f Mar 11, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build succeeded.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Mar 11, 2020

recheck

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build failed.

@lachmanfrantisek lachmanfrantisek merged commit 1f72cda into packit-service:master Mar 11, 2020
3 of 5 checks passed
3 of 5 checks passed
local/check check status: failure
Details
local/gate gate status: failure
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
ci/dockercloud (/Dockerfile.worker) Your tests passed in Docker Cloud
Details
@lachmanfrantisek lachmanfrantisek deleted the lachmanfrantisek:mapping branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.