Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not overwrite git_ref in CoprBuildEvent #496

Conversation

@lbarcziova
Copy link
Contributor

lbarcziova commented Mar 16, 2020

May fix #495

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 16, 2020

Build succeeded.

Copy link
Member

jpopelka left a comment

Thanks!

Copy link
Member

lachmanfrantisek left a comment

Thanks for finding the problem and fixing that!

self.base_repo_name = build_pg.pr.project.repo_name
self.base_repo_namespace = build_pg.pr.project.namespace
# FIXME: hardcoded, move this to PG
https_url = f"https://github.com/{self.base_repo_namespace}/{self.base_repo_name}.git"
git_ref = self.commit_sha # ref should be name of the branch, not a hash

This comment has been minimized.

Copy link
@lachmanfrantisek

lachmanfrantisek Mar 17, 2020

Member

Moving down does not help, but the rewriting will help definitely.

An alternative solution can be to move the super call up and safely write these values after that. What do you think?

This comment has been minimized.

Copy link
@lbarcziova

lbarcziova Mar 17, 2020

Author Contributor

yes, that was my first idea, but we need to get https_url from the db info as it is passed to the super constructor

This comment has been minimized.

Copy link
@lachmanfrantisek

lachmanfrantisek Mar 17, 2020

Member

Good point. Then maybe only the https_url before the super calls.

(Feel free to merge it as is. I just don't like a lot of code before the super call. It usually leads to this kind of weird errors...)

This comment has been minimized.

Copy link
@lbarcziova

lbarcziova Mar 17, 2020

Author Contributor

I will leave it as it is for now, as here https_url = f"https://github.com/{self.base_repo_namespace}/{self.base_repo_name}.git" we need other attributes anyway.

@lbarcziova lbarcziova added the mergeit label Mar 17, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 17, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a81043f into packit-service:master Mar 17, 2020
5 checks passed
5 checks passed
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
ci/dockercloud (/Dockerfile.worker) Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
@jpopelka jpopelka mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.