Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event argument for handlers #510

Conversation

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Mar 18, 2020

  • Use name 'event' for all handlers to match the call in jobs.
  • Fixes RED-HAT-0P-2BK
@sentry-io

This comment has been minimized.

Copy link

sentry-io bot commented Mar 18, 2020

Sentry issue: RED-HAT-0P-2BK

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build failed.

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Mar 18, 2020

recheck

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build failed.

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Mar 18, 2020

recheck

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build failed.

Copy link
Contributor

TomasTomecek left a comment

LGTM

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:fix-event-argument-for-handlers branch from 50a697c to a70af9d Mar 18, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build succeeded.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 27b9224 into packit-service:master Mar 18, 2020
3 checks passed
3 checks passed
LGTM analysis: Python No new or fixed alerts
Details
local/check check status: success
Details
local/gate gate status: success
Details
@lachmanfrantisek lachmanfrantisek deleted the lachmanfrantisek:fix-event-argument-for-handlers branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.