Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull-Request have been deactivated for this project #328

Closed
nforro opened this issue May 16, 2019 · 7 comments

Comments

@nforro
Copy link
Contributor

commented May 16, 2019

I'm trying to rebase rebase-helper with packit, however, packit is unable to create pull request on Pagure. I even tried to generate new API keys, same error.

$ packit version
0.2.0
$ packit -d propose-update https://github.com/rebase-helper/rebase-helper.git
11:07:08.292 packit_base.py    DEBUG  logging set to DEBUG
Cloning repo: https://github.com/rebase-helper/rebase-helper.git -> /tmp/tmp224hcoj_
11:07:10.376 local_project.py  DEBUG  namespace from url is rebase-helper
11:07:10.376 config.py         DEBUG  The local config file '/home/nforro/.packit.yaml' not found.
11:07:10.377 config.py         DEBUG  The local config file '/home/nforro/.packit.yml' not found.
11:07:10.377 config.py         DEBUG  The local config file '/home/nforro/.packit.json' not found.
11:07:10.377 config.py         DEBUG  The local config file '/home/nforro/packit.yaml' not found.
11:07:10.377 config.py         DEBUG  The local config file '/home/nforro/packit.yml' not found.
11:07:10.377 config.py         DEBUG  The local config file '/home/nforro/packit.json' not found.
11:07:10.377 config.py         DEBUG  The local config file '/tmp/tmp224hcoj_/.packit.yaml' not found.
11:07:10.377 config.py         DEBUG  Local package config found: /tmp/tmp224hcoj_/.packit.yml
11:07:10.378 config.py         DEBUG  Package config:
{
    "specfile_path": "rebase-helper.spec",
    "synced_files": [
        ".packit.yml",
        "rebase-helper.spec"
    ],
    "upstream_project_name": "rebase-helper",
    "downstream_package_name": "rebase-helper"
}
11:07:10.380 distgit.py        DEBUG  Using dist-git repo None
Version in upstream registries is '0.16.3'.
11:07:10.937 local_project.py  DEBUG  working_dir is set and git_repo is not: let's discover...
11:07:10.938 local_project.py  DEBUG  it's a git repo!
11:07:10.944 local_project.py  DEBUG  remote url of the repo is https://github.com/rebase-helper/rebase-helper.git
11:07:10.945 local_project.py  DEBUG  namespace from url is rebase-helper
Version in spec file is '0.16.3'.
Picking version of the latest release from the upstream registry over spec file.
Checking out upstream version 0.16.3
Using 'master' dist-git branch
09:07:11.082 distgit.py        DEBUG  About to create a new git branch 'master' in dist-git
Cloning repo: https://src.fedoraproject.org/rpms/rebase-helper.git -> /tmp/tmp8j5ylbyj
09:07:13.351 distgit.py        DEBUG  About to update branch 'master'
09:07:14.128 distgit.py        DEBUG  About to checkout 'master'
09:07:14.134 distgit.py        DEBUG  About to create a new git branch '0.16.3-master-update' in dist-git
09:07:14.136 distgit.py        DEBUG  About to checkout '0.16.3-master-update'
09:07:14.147 distgit.py        DEBUG  About to sync files ['.packit.yml', 'rebase-helper.spec']
Syncing /tmp/tmp224hcoj_/.packit.yml
Syncing /tmp/tmp224hcoj_/rebase-helper.spec
09:07:14.250 distgit.py        DEBUG  Upstream archive name is 'rebase-helper-0.16.3.tar.gz'
Archive rebase-helper-0.16.3.tar.gz found in lookaside cache (skipping upload).
09:07:14.818 distgit.py        DEBUG  Upstream archive name is 'rebase-helper-0.16.3.tar.gz'
INFO: Running 'anitya' versioneer
INFO: Downloading file from URL https://github.com/rebase-helper/rebase-helper/archive/0.16.3/rebase-helper-0.16.3.tar.gz
    [       <=>                    ]     1.80M   in 00:00:00 
09:07:16.717 distgit.py        DEBUG  Upstream archive name is 'rebase-helper-0.16.3.tar.gz'
Downloaded archive: '/tmp/tmp8j5ylbyj/rebase-helper-0.16.3.tar.gz'
About to upload to lookaside cache
won't be doing kinit, no credentials provided
09:07:16.718 utils.py          DEBUG  cmd = ['fedpkg', 'new-sources', '/tmp/tmp8j5ylbyj/rebase-helper-0.16.3.tar.gz']
09:07:18.828 utils.py          DEBUG  File already uploaded: /tmp/tmp8j5ylbyj/rebase-helper-0.16.3.tar.gz
Source upload succeeded. Don't forget to commit the sources file

09:07:18.828 distgit.py        DEBUG  About to add all & commit
09:07:18.845 distgit.py        DEBUG  About to force push changes to branch 0.16.3-master-update of a fork fork of the dist-git repo
09:07:29.188 distgit.py        DEBUG  About to create dist-git pull request from 0.16.3-master-update to master
ERROR    There was an error while creating the PR: APIError('Pull-Request have been deactivated for this project')
ERROR    Pull-Request have been deactivated for this project
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/packit/cli/utils.py", line 35, in covered_func
    func(config=config, *args, **kwargs)
  File "/usr/lib/python3.7/site-packages/packit/cli/update.py", line 71, in update
    force_new_sources=force_new_sources,
  File "/usr/lib/python3.7/site-packages/packit/api.py", line 121, in sync_release
    force_new_sources=force_new_sources,
  File "/usr/lib/python3.7/site-packages/packit/api.py", line 223, in sync
    target_branch=dist_git_branch,
  File "/usr/lib/python3.7/site-packages/packit/distgit.py", line 242, in create_pull
    target_branch=target_branch,
  File "/usr/lib/python3.7/site-packages/ogr/services/pagure.py", line 145, in pr_create
    source_branch=source_branch,
  File "/usr/lib/python3.7/site-packages/ogr/services/our_pagure.py", line 145, in create_request
    "initial_comment": body,
  File "/usr/lib/python3.7/site-packages/libpagure/libpagure.py", line 87, in _call_api
    raise APIError(output['error'])
libpagure.exceptions.APIError: Pull-Request have been deactivated for this project
09:07:32.153 local_project.py  DEBUG  Cleaning: /tmp/tmp8j5ylbyj
09:07:32.158 local_project.py  DEBUG  Cleaning: /tmp/tmp224hcoj_
@phracek

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

This has been already filed as a bug in Pagure https://pagure.io/pagure/issue/4416. Based on the roadmap only two issues are missing (https://pagure.io/pagure/roadmap/5.6/) for releasing new Pagure which is gonna fixed that. We are planning to use OGR for filing PRs and get rid off libpagure.

@lachmanfrantisek

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Just for clarification, it is a regression in the Pagure API.

We are planning to use OGR for filing PRs and get rid off libpagure.

This does not help with this issue, but yes, we would like to implement the Python API for Pagure from scratch.

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

Thanks guys, good and precise answers.

@nforro, this has an easy workaround: open https://src.fedoraproject.org/ web interface and create the pull request manually.

@phracek

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

@nforro This issue should be already fixed by Pagure.IO (https://pagure.io/pagure/roadmap/5.6/). Can you please try again with the newest packit version released on PyPi.
Thanks.

@nforro

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

The fix doesn't seem to be deployed yet, I'm still getting the same error (with packit 0.4.1).

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

That's correct, they still haven't fixed it. Our plans to get around this is to support pushing directly to dist-git.

You can also watch for the fix yourself: https://src.fedoraproject.org/dashboard/projects needs to say pagure 5.6 (it's 5.5 now).

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

This is already documented and a proper doc string is printed if this happens:

if "Pull-Request have been deactivated" in str(ex):

packit-service/packit.dev#34

Thanks for taking time to open this issue. In the meantime, when we release new version of packit (0.5.0), you'll be able to push directly to dist-git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.