Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases #619

Merged
Merged

Conversation

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Dec 3, 2019

Fixes (partially) #540

  • Only the packit part. Service needs to be updated as well.

  • Aliases:

    "fedora-development": ["fedora-rawhide", "fedora-32"]
    "fedora-stable": ["fedora-30", "fedora-31"]
    "fedora-all": ["fedora-rawhide", "fedora-32", "fedora-30", "fedora-31"]
  • Add alias mapping to version, build-target and branch.
  • CLI command support:
    • packit propose-update
    • packit sync-from-downstream
    • packit copr-build
    • packit build
    • packit create-update
  • The CLI should work at least as before. I'll create the integration tests for the multiple branches in/after #612
@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Dec 3, 2019

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-619
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 3, 2019

Build failed.

@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:aliases branch from efb6c68 to 8fc7356 Dec 3, 2019
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 3, 2019

Build failed.

@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:aliases branch from 8fc7356 to 5f5e46a Dec 3, 2019
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 3, 2019

Build failed.

@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:aliases branch from 5f5e46a to bdc18c9 Dec 3, 2019
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 3, 2019

Build succeeded.

@lachmanfrantisek

This comment was marked as outdated.

Copy link
Member Author

lachmanfrantisek commented Dec 4, 2019

recheck

@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded.

@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded.

@lachmanfrantisek lachmanfrantisek changed the title WIP: aliases Aliases Dec 4, 2019
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded.

Copy link
Contributor

TomasTomecek left a comment

I'm so glad this PR is not +50476 -49764.

Didn't try it but after code review, it looks really solid. So, LGTM

will you also update doks after p-s part is done?

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Dec 4, 2019

will you also update doks after p-s part is done?

Sure. After the p-s part is done.

@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:aliases branch from 8f2c226 to e693392 Dec 4, 2019
@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Dec 4, 2019

@TomasTomecek updated, PTAL

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded.

Copy link
Contributor

TomasTomecek left a comment

I TAL'd and LGTMing this.

@TomasTomecek TomasTomecek added the mergeit label Dec 4, 2019
@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Dec 4, 2019

needz rebase, sorry buddy

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the lachmanfrantisek:aliases branch from e693392 to 784b2ce Dec 4, 2019
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 4, 2019

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8670bc1 into packit-service:master Dec 4, 2019
3 of 9 checks passed
3 of 9 checks passed
packit/rpm-build-fedora-30-x86_64 RPM build has just started...
Details
packit/rpm-build-fedora-31-x86_64 RPM build has just started...
Details
packit/rpm-build-fedora-rawhide-x86_64 RPM build has just started...
Details
packit/testing-farm-fedora-30-x86_64 Waiting for a successful RPM build
Details
packit/testing-farm-fedora-31-x86_64 Waiting for a successful RPM build
Details
packit/testing-farm-fedora-rawhide-x86_64 Waiting for a successful RPM build
Details
local/check check status: success
Details
local/gate gate status: success
Details
packit/srpm-build SRPM was built successfully.
Details
@lachmanfrantisek lachmanfrantisek deleted the lachmanfrantisek:aliases branch Dec 4, 2019
@jpopelka

This comment has been minimized.

Copy link
Member

jpopelka commented Dec 13, 2019

@lachmanfrantisek can we have the aliases in the documentation ?

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Dec 13, 2019

@lachmanfrantisek can we have the aliases in the documentation ?

Yes, sorry about that. That will be the first thing I am going to do on Monday...;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.