Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for finding spec file #634

Merged
merged 4 commits into from Feb 3, 2020

Conversation

@lbarcziova
Copy link
Contributor

lbarcziova commented Dec 11, 2019

No description provided.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 11, 2019

Build succeeded.

@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Dec 11, 2019

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-634
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@lbarcziova lbarcziova force-pushed the lbarcziova:find_specfile branch from 56e4776 to 2d70625 Jan 21, 2020
@lbarcziova lbarcziova changed the title WIP: add methods for finding spec file Add methods for finding spec file Jan 21, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 21, 2020

Build failed.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 21, 2020

Build failed.

Copy link
Member

jpopelka left a comment

I see some test fails on

flexmock.FlexmockError: <class 'ogr.abstract.GitProject'> does not have attribute get_files
packit/config/package_config.py Outdated Show resolved Hide resolved
packit/config/package_config.py Outdated Show resolved Hide resolved
@lbarcziova

This comment has been minimized.

Copy link
Contributor Author

lbarcziova commented Jan 23, 2020

I see some test fails

I think it is because the function get_files() in ogr was just merged and now it is only in master, where the tests pass.

@lbarcziova lbarcziova force-pushed the lbarcziova:find_specfile branch from 831d1e8 to 253341a Jan 23, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 23, 2020

Build failed.

@jpopelka

This comment has been minimized.

Copy link
Member

jpopelka commented Jan 23, 2020

I think it is because the function get_files() in ogr was just merged and now it is only in master, where the tests pass.

Ok, it makes sense.

The thing is that in the packit-service-worker image (which is based on packit image) we use the python3-ogr RPM from Fedora.
So we can't merge this until that get_files() change is part of python3-ogr in Fedora if we don't want to break stg/prod.

Time for new ogr release @lachmanfrantisek ?

@lachmanfrantisek

This comment has been minimized.

Copy link
Member

lachmanfrantisek commented Jan 23, 2020

Time for new ogr release @lachmanfrantisek ?

Sure. I'll take a look at the opened PR and we can release a new OGR...

@lbarcziova lbarcziova force-pushed the lbarcziova:find_specfile branch from 253341a to 8fba33d Jan 27, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 27, 2020

Build failed.

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Jan 28, 2020

needs rebase 🌞

@lbarcziova lbarcziova force-pushed the lbarcziova:find_specfile branch from 8fba33d to df4cfb0 Jan 28, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 28, 2020

Build failed.

@lbarcziova lbarcziova force-pushed the lbarcziova:find_specfile branch from df4cfb0 to 9d0191f Jan 29, 2020
@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Jan 29, 2020

There was an error while creating SRPM. You can re-trigger build by adding a comment (/packit copr-build) into this pull request.

Output:

Preparing of the upstream to the SRPM build failed: (403)
Reason: Forbidden
HTTP response headers: HTTPHeaderDict({'Cache-Control': 'no-store', 'Content-Type': 'application/json', 'Date': 'Wed, 29 Jan 2020 13:45:16 GMT', 'Content-Length': '465'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"persistentvolumeclaims \"sandcastle--sandcastle-20200129-134516488485-pvc\" is forbidden: exceeded quota: 74746f6d6563656b407265646861742e636f6d-noncompute, requested: requests.storage=1Gi, used: requests.storage=23Gi, limited: requests.storage=23Gi","reason":"Forbidden","details":{"name":"sandcastle--sandcastle-20200129-134516488485-pvc","kind":"persistentvolumeclaims"},"code":403}


@lbarcziova

This comment has been minimized.

Copy link
Contributor Author

lbarcziova commented Jan 29, 2020

/packit copr-build

@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Jan 29, 2020

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-634
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 29, 2020

Build failed.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 29, 2020

Build failed.

@jpopelka

This comment has been minimized.

Copy link
Member

jpopelka commented Feb 3, 2020

recheck

@jpopelka

This comment has been minimized.

Copy link
Member

jpopelka commented Feb 3, 2020

/packit build

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 3, 2020

Build failed.

@jpopelka

This comment has been minimized.

Copy link
Member

jpopelka commented Feb 3, 2020

* packit-tests-rpm  : FAILURE in 5m 45s

#694 should address that. I'll rebase once it's merged.

@jpopelka jpopelka force-pushed the lbarcziova:find_specfile branch from 0c3b293 to b12c5ab Feb 3, 2020
lbarcziova added 4 commits Dec 11, 2019
@jpopelka jpopelka added the mergeit label Feb 3, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 3, 2020

Build failed.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 3, 2020

Build succeeded.

@jpopelka jpopelka added mergeit and removed mergeit labels Feb 3, 2020
@jpopelka

This comment has been minimized.

Copy link
Member

jpopelka commented Feb 3, 2020

Hmm, is mergeit label not working anymore?
Merging myself.

@jpopelka jpopelka merged commit 2b03405 into packit-service:master Feb 3, 2020
7 of 8 checks passed
7 of 8 checks passed
packit/testing-farm-fedora-30-x86_64 Tests are running ...
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
local/check check status: success
Details
packit/rpm-build-fedora-30-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-31-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-rawhide-x86_64 RPMs were built successfully.
Details
packit/testing-farm-fedora-31-x86_64 All tests passed
Details
@jpopelka

This comment has been minimized.

Copy link
Member

jpopelka commented Feb 7, 2020

@lbarcziova can we have the documentation changed as well, please?

@lbarcziova

This comment has been minimized.

Copy link
Contributor Author

lbarcziova commented Feb 7, 2020

@jpopelka yes, I will change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.