Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove else from 'for' when no 'break' present #636

Conversation

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
packit/upstream.py Outdated Show resolved Hide resolved
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 13, 2019

Build succeeded.

@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Dec 13, 2019

This pull request fixes 1 alert when merging f7b9f40 into b29a809 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 13, 2019

Build succeeded.

@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Dec 13, 2019

This pull request fixes 1 alert when merging 9df5477 into b29a809 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop
@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Dec 13, 2019

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-636
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 13, 2019

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b6d9bf7 into packit-service:master Dec 13, 2019
11 checks passed
11 checks passed
LGTM analysis: Python 1 fixed alert
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
packit/rpm-build-fedora-30-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-31-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-rawhide-x86_64 RPMs were built successfully.
Details
packit/srpm-build SRPM was built successfully.
Details
packit/testing-farm-fedora-30-x86_64 All tests passed
Details
packit/testing-farm-fedora-31-x86_64 All tests passed
Details
packit/testing-farm-fedora-rawhide-x86_64 All tests passed
Details
@lachmanfrantisek lachmanfrantisek deleted the lachmanfrantisek:fix-for-else branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.