Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug in copr-build command #713

Merged

Conversation

@lbarcziova
Copy link
Contributor

lbarcziova commented Feb 18, 2020

Fixes #688
The problem was that the ownername argument in create_from_file method was not set to the config value (was None).

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 18, 2020

Build succeeded.

@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Feb 18, 2020

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-713
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@lbarcziova

This comment has been minimized.

Copy link
Contributor Author

lbarcziova commented Feb 18, 2020

/packit test

Copy link
Member

jpopelka left a comment

Works, you rock!

@lbarcziova lbarcziova added the mergeit label Feb 18, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 18, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 302b2ef into packit-service:master Feb 18, 2020
9 checks passed
9 checks passed
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
packit/rpm-build-fedora-30-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-31-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-rawhide-x86_64 RPMs were built successfully.
Details
packit/testing-farm-fedora-30-x86_64 All tests passed
Details
packit/testing-farm-fedora-31-x86_64 All tests passed
Details
@TomasTomecek

This comment has been minimized.

Copy link
Contributor

TomasTomecek commented Feb 19, 2020

Works, you rock!

You're so mean! Calling Laura a rock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.