Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] add --upstream-ref to copr-build #718

Conversation

@jpopelka
Copy link
Member

jpopelka commented Feb 20, 2020

to support copr build from source-git

@jpopelka jpopelka marked this pull request as ready for review Feb 20, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 20, 2020

Build succeeded.

@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Feb 20, 2020

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-718
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

lachmanfrantisek left a comment

What about the upstream-ref option in the config, can we also use that one?

https://packit.dev/docs/configuration/#upstream-ref

to support copr build from source-git
@jpopelka

This comment has been minimized.

Copy link
Member Author

jpopelka commented Feb 20, 2020

What about the upstream-ref option in the config, can we also use that one?

It is used if the --upstream-ref is not specified:
copr_build() -> create_srpm() -> prepare_upstream_for_srpm_creation -> upstream_ref or self.package_config.upstream_ref

@jpopelka jpopelka added the mergeit label Feb 20, 2020
@jpopelka jpopelka force-pushed the jpopelka:cli-copr-build-upstream-ref branch from 3db7811 to 723aab0 Feb 20, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 20, 2020

Build succeeded.

@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 20, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0b6261e into packit-service:master Feb 20, 2020
9 checks passed
9 checks passed
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
packit/rpm-build-fedora-30-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-31-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-rawhide-x86_64 RPMs were built successfully.
Details
packit/testing-farm-fedora-30-x86_64 All tests passed
Details
packit/testing-farm-fedora-31-x86_64 All tests passed
Details
@jpopelka jpopelka deleted the jpopelka:cli-copr-build-upstream-ref branch Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.