Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream git-log inside rpm %changelog #889

Merged
merged 2 commits into from Jul 7, 2020
Merged

upstream git-log inside rpm %changelog #889

merged 2 commits into from Jul 7, 2020

Conversation

TomasTomecek
Copy link
Member

Use git-describe to get latest git tag and then using git-log obtain all
commit messages b/w {last_tag}..HEAD and feed the output to %changelog

  • fall back to old behaviour when git-log or git-describe fails
  • former tests were too complicated - simplify them or merge into
    existing one

Fixes #738
Carries #776

@TomasTomecek TomasTomecek changed the title git log in %changelog fixups upstream git-log inside rpm %changelog Jul 7, 2020
@packit-as-a-service-stg
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-889-stg
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@TomasTomecek TomasTomecek added the ready-for-review Pull request is ready for review. label Jul 7, 2020
@TomasTomecek TomasTomecek added the mergeit When set, zuul wil gate and merge the PR. label Jul 7, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline).

ffoto1620 and others added 2 commits July 7, 2020 16:42
@ffoto1620 @TomasTomecek
Replace changelog message with actual commit message
1f64197
@TomasTomecek
git log in %changelog fixups
a2395aa 
Use git-describe to get latest git tag and then using git-log obtain all
commit messages b/w {last_tag}..HEAD and feed the output to %changelog

* fall back to old behaviour when git-log or git-describe fails
* former tests were too complicated - simplify them or merge into
  existing one

Fixes packit#738
Carries packit#776

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@lachmanfrantisek
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 917e41b into packit:master Jul 7, 2020
@TomasTomecek TomasTomecek deleted the carry-776 branch July 7, 2020 15:12
@TomasTomecek TomasTomecek mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR. ready-for-review Pull request is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "Development snapshot (<hash>)" changelog with actual commit messages
3 participants
@TomasTomecek @lachmanfrantisek @ffoto1620