Create a Bugzilla bug for a new Merge Request (Gitlab) #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the handlers there support all git forges now.
It will support Gitlab as well.
This comment has been minimized.
This comment has been minimized.
See handlers/__init__.py to know what is where now
i.e.
from packit_service.worker.handlers.abstract import (
Handler,
JobHandler,
FedmsgHandler,
)
from packit_service.worker.handlers.copr_handlers import (
CoprBuildHandler,
CoprBuildEndHandler,
CoprBuildStartHandler,
)
from packit_service.worker.handlers.distgit_handlers import (
DistGitCommitHandler,
ProposeDownstreamHandler,
)
from packit_service.worker.handlers.forges_handlers import (
GithubAppInstallationHandler,
PullRequestLabelHandler,
)
from packit_service.worker.handlers.koji_handlers import (
KojiBuildHandler,
KojiBuildReportHandler,
)
from packit_service.worker.handlers.testing_farm_handlers import (
TestingFarmHandler,
TestingFarmResultsHandler,
)
jpopelka
force-pushed
the
bugzilla-from-gitlab
branch
from
67c59f4
to
a49d754
Compare
|
Build succeeded.
|
lachmanfrantisek
approved these changes
May 5, 2021
jpopelka
force-pushed
the
bugzilla-from-gitlab
branch
from
a49d754
to
d47c57d
Compare
|
Build succeeded.
|
jpopelka
changed the title
jpopelka
force-pushed
the
bugzilla-from-gitlab
branch
from
d47c57d
to
d1613ea
Compare
|
Build succeeded.
|
It's been renamed from PagurePullRequestLabelHandler and reacts to MergeRequestGitlabEvent (which now has also source_repo_branch & target_repo_branch attributes). Creating a Bugzilla bug is no longer a reaction to added label, but triggered by opening a new MR and is now restricted to set of allowed namespaces and branches. The now unused code for handling labels on Pagure has been removed.
jpopelka
force-pushed
the
bugzilla-from-gitlab
branch
from
d1613ea
to
ccc6fa9
Compare
|
Build succeeded.
|
lachmanfrantisek
approved these changes
May 10, 2021
|
Do you think we will ever need to react on labels? (I am just thinking about whether it makes sense to preserve the parsing you've implemented and is now not present?) |
I can easily imagine a future workflow where p-s, or probably "the-new-thing", will react to labels. |
It's gone, sorry :-) Thanks for review, will merge this after we move stable branches today. |
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an "accepted" flag is added to a MR in a source-git repo, create a bug in Bugzilla against that component for the CentOS Stream version.
We already have the functionality for Pagure, but because we've moved our source-git repos to Gitlab we need support for Gitlab.
Since this MR flag -> BZ workflow is c8s specific and we won't go back to Pagure, this PR removes the relevant Pagure related pieces.
There are some refactoring commits, so it's better to check them separately.