Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Whitelist.check_and_report] check if namespace approved when IssueComment #309

Merged

Conversation

jpopelka
Copy link
Member

@jpopelka jpopelka commented Dec 19, 2019

Fixes #308

@jpopelka jpopelka force-pushed the IssueCommentEvent-is-namespace-approved branch from 0a2c376 to f96581d Compare Dec 19, 2019
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Looks good.

@jpopelka jpopelka force-pushed the IssueCommentEvent-is-namespace-approved branch from eb358dc to bc3ec0f Compare Dec 19, 2019
@packit packit deleted a comment from softwarefactory-project-zuul bot Dec 19, 2019
@packit packit deleted a comment from softwarefactory-project-zuul bot Dec 19, 2019
@packit packit deleted a comment from softwarefactory-project-zuul bot Dec 19, 2019
jpopelka added 5 commits Dec 19, 2019
Merge test_check_and_report_pr_comment_reject() & test_check_and_report_pr_comment_approve()
and test also IssueCommentEvent
'events' fixture generates all combinations of (Event, namespace, login, approved)
@jpopelka jpopelka requested a review from TomasTomecek Dec 19, 2019
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Dec 19, 2019

Build failed.

Copy link
Member

@TomasTomecek TomasTomecek left a comment

LGTM

packit_service/worker/whitelist.py Show resolved Hide resolved
@TomasTomecek TomasTomecek merged commit 5c31396 into packit:master Jan 2, 2020
3 of 4 checks passed
@jpopelka jpopelka deleted the IssueCommentEvent-is-namespace-approved branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants