Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch failed SRPM build #311

Merged
merged 1 commit into from Jan 7, 2020

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek commented Jan 6, 2020

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 6, 2020

Build failed.

Copy link
Member

@jpopelka jpopelka left a comment

  • there are some tests failing
  • why not fix it directly in packit?

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Jan 6, 2020

* there are some tests failing

I'll fix that.

* why not fix it directly in packit?

I wanted to fix that here as soon as possible and forget that we do not need to release packit to have it in the service -- I'll fix that directly in packit.

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Jan 7, 2020

I'll fix that directly in packit.

Here it is: packit/packit#650

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 7, 2020

Build failed.

@jpopelka jpopelka added the mergeit When set, zuul wil gate and merge the PR. label Jan 7, 2020
@jpopelka jpopelka merged commit a37372f into packit:master Jan 7, 2020
3 of 4 checks passed
@lachmanfrantisek lachmanfrantisek deleted the catch-failed-srpm branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants