Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load service config only once #318

Merged
merged 3 commits into from Jan 9, 2020

Conversation

TomasTomecek
Copy link
Member

@TomasTomecek TomasTomecek commented Jan 9, 2020

Fixes #153

Fixes packit#153

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 9, 2020

Build failed.

TomasTomecek added 2 commits Jan 9, 2020
`make check_in_container` can remove the current working directory w/o
this patch

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek
Copy link
Member Author

TomasTomecek commented Jan 9, 2020

locally service tests now === 62 passed, 3 warnings in 3.42 seconds ===

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 9, 2020

Build failed.

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Jan 9, 2020

I don't have the patience to deal with requre tests right now.

@TomasTomecek TomasTomecek merged commit cca4e2d into packit:master Jan 9, 2020
1 of 2 checks passed
@TomasTomecek TomasTomecek deleted the service-config-singleton branch Jan 13, 2020

logger = logging.getLogger("packit_service")
# no need to thank me, just buy me a beer
logger.debug(f"URL map = {application.url_map}")
Copy link
Member

@jpopelka jpopelka Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some strange reason there's [wsgi:error] in the output:

[Wed Jan 15 08:09:54.088320 2020] [wsgi:error] [pid 19:tid 140426144958208] 08:09:54.088 app.py            DEBUG  URL map = Map([<Rule '/api/testing-farm/results' (OPTIONS, POST) -> api.testing-farm_testing_farm_results>,
[Wed Jan 15 08:09:54.088354 2020] [wsgi:error] [pid 19:tid 140426144958208]  <Rule '/api/webhooks/github' (OPTIONS, POST) -> api.webhooks_github_webhook>,

Copy link
Member Author

@TomasTomecek TomasTomecek Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that everything printed by the wsgi app is printed as errors, which is really weird; maybe it can be confiigured in the httpd config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants