Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit changes #383

Merged
merged 6 commits into from Feb 6, 2020
Merged

Conversation

jpopelka
Copy link
Member

@jpopelka jpopelka commented Feb 4, 2020

Fixes #385

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 4, 2020

Build failed.

@jpopelka jpopelka force-pushed the pre-commit branch 2 times, most recently from 3b01c64 to f898e78 Compare Feb 5, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 5, 2020

Build failed.

jpopelka added a commit to jpopelka/packit-service that referenced this pull request Feb 5, 2020
Tests in my packit#383 are failing and I don't get it.

This is supposed to be a proof of my innocence.
@jpopelka jpopelka mentioned this pull request Feb 5, 2020
@jpopelka jpopelka marked this pull request as ready for review Feb 6, 2020
@jpopelka jpopelka added the ready-for-review Pull request is ready for review. label Feb 6, 2020
@jpopelka jpopelka requested a review from csomh Feb 6, 2020
Recently, ansible started to warn:
[DEPRECATION WARNING]: Distribution fedora 31 on host localhost should use
/usr/bin/python3, but is using /usr/bin/python for backward compatibility with
prior Ansible releases. A future Ansible release will default to using the
discovered platform python for this host. See https://docs.ansible.com/ansible/
2.9/reference_appendices/interpreter_discovery.html for more information. This
feature will be removed in version 2.12. Deprecation warnings can be disabled
by setting deprecation_warnings=False in ansible.cfg.
@jpopelka jpopelka added the mergeit When set, zuul wil gate and merge the PR. label Feb 6, 2020
csomh
csomh approved these changes Feb 6, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 6, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 6, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 14777bb into packit:master Feb 6, 2020
5 checks passed
@jpopelka jpopelka deleted the pre-commit branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR. ready-for-review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing tests
2 participants