Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty tests in testing farm result #388

Merged
merged 1 commit into from Feb 12, 2020

Conversation

dhodovsk
Copy link
Contributor

@dhodovsk dhodovsk commented Feb 10, 2020

The use should stay fine even with empty list: https://github.com/packit-service/packit-service/blob/master/packit_service/worker/testing_farm_handlers.py#L80

The log message will be:

Received testing-farm test results:
[]

Let me know if you want to change that.

@dhodovsk
Copy link
Contributor Author

dhodovsk commented Feb 10, 2020

Fixes #387

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 10, 2020

Build failed.

@TomasTomecek
Copy link
Member

TomasTomecek commented Feb 10, 2020

recheck

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 10, 2020

Build failed.

@TomasTomecek
Copy link
Member

TomasTomecek commented Feb 10, 2020

recheck

@TomasTomecek
Copy link
Member

TomasTomecek commented Feb 10, 2020

Hm, the openshift cluster no longer starts:

E0210 11:44:27.873566   22593 run_self_hosted.go:571] API server error: Get https://127.0.0.1:8443/healthz?timeout=32s: dial tcp 127.0.0.1:8443: connect: connection refused ()
Error: timed out waiting for the condition

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 10, 2020

Build failed.

@dhodovsk dhodovsk added the mergeit When set, zuul wil gate and merge the PR. label Feb 11, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 12, 2020

Build failed.

Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Merging. I'll add tests for it myself in my PR (#391)

@lachmanfrantisek lachmanfrantisek merged commit 98d34c0 into packit:master Feb 12, 2020
1 of 2 checks passed
@dhodovsk dhodovsk linked an issue Feb 13, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing errors are not displayed
3 participants