Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build logs view + data in psql #406

Merged
merged 5 commits into from Feb 20, 2020

Conversation

TomasTomecek
Copy link
Member

@TomasTomecek TomasTomecek commented Feb 14, 2020

replaces #257 #297

Fixes #1
Fixes #264

  • tests pass in CI
    • utilize pg and redis deployed w/ requre tests
  • have a succ build on stg w/ good logs
  • move PR comments to logs (new PR)
  • SRPM check has logs

Base = declarative_base()


class GitHubProject(Base):
Copy link
Member Author

@TomasTomecek TomasTomecek Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the PSQL schema.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build succeeded.

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Feb 14, 2020

Build succeeded.

* [packit-service-pre-commit ](https://softwarefactory-project.io/zuul/t/local/build/c6814080d8b94080a6cbb650b87f3f0d) : SUCCESS in 3m 14s

* [packit-service-tests ](https://softwarefactory-project.io/zuul/t/local/build/dcd2c446e13e4ca981b8d794173db51c) : SUCCESS in 13m 43s

* [packit-service-tests-requre ](https://softwarefactory-project.io/zuul/t/local/build/f381a7b3e9fb4656bfcedb52fcfd5ad2) : SUCCESS in 15m 35s

WHAT?! that's not possible

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build failed.

Copy link
Member

@jpopelka jpopelka left a comment

respect

files/install-deps-worker.yaml Outdated Show resolved Hide resolved
@TomasTomecek TomasTomecek changed the title build logs view + data in psql wip: build logs view + data in psql Feb 14, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 14, 2020

Build succeeded.

csomh
csomh approved these changes Feb 17, 2020
Copy link
Member

@csomh csomh left a comment

I have a few borderline nitpicking comments, but other than that this looks great! 🚀

Good to be merged once you are happy with testing.

alembic/env.py Outdated Show resolved Hide resolved
packit_service/service/urls.py Outdated Show resolved Hide resolved
packit_service/models.py Outdated Show resolved Hide resolved
@TomasTomecek
Copy link
Member Author

TomasTomecek commented Feb 17, 2020

thanks for the comments, pushed changes to address them, also realised the schema is not applied, hence the sentry issue https://sentry.io/organizations/red-hat-0p/issues/1518475677/

built && pushed new stg image, let's see tomorrow

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 17, 2020

Build succeeded.

@TomasTomecek TomasTomecek changed the title wip: build logs view + data in psql build logs view + data in psql Feb 18, 2020
@TomasTomecek TomasTomecek added the ready-for-review Pull request is ready for review. label Feb 18, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 18, 2020

Build failed.

@csomh
Copy link
Member

csomh commented Feb 19, 2020

Tests fail because

Unable to find '../secrets/dev/dashboard-privkey.pem' in expected

@sakalosj I think the tests should be updated to set up dashboard-privkey.pem after the recent deployment changes.

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Feb 19, 2020

Tests fail because

Unable to find '../secrets/dev/dashboard-privkey.pem' in expected

@sakalosj I think the tests should be updated to set up dashboard-privkey.pem after the recent deployment changes.

shoiuld be fixed in 2842c46

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build failed.

@sakalosj
Copy link
Contributor

sakalosj commented Feb 19, 2020

Tests fail because

Unable to find '../secrets/dev/dashboard-privkey.pem' in expected

@sakalosj I think the tests should be updated to set up dashboard-privkey.pem after the recent deployment changes.

shoiuld be fixed in 2842c46

thanks - wasnt aware of this

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Feb 19, 2020

#414 to fix CI

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build failed.

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Feb 19, 2020

recheck

since the whole service is deployed

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
we have it deployed already as part of p-s

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 19, 2020

Build succeeded.

* store SRPM logs in a dedicated table

* build logs: utilize our IDs instead of COPR build IDs

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek
Copy link
Member Author

TomasTomecek commented Feb 20, 2020

Finally a successful build, merging packit/hello-world#78

@TomasTomecek TomasTomecek added the mergeit When set, zuul wil gate and merge the PR. label Feb 20, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 20, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Feb 20, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b95a4a7 into packit:master Feb 20, 2020
4 checks passed
@TomasTomecek TomasTomecek deleted the logs2 branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR. ready-for-review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve redis server handling in tests Store and provide logs in packit service
4 participants