Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry integration for service #458

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek commented Mar 6, 2020

@lachmanfrantisek lachmanfrantisek requested a review from jpopelka Mar 6, 2020
@lachmanfrantisek lachmanfrantisek force-pushed the sentry-integration-for-service branch 2 times, most recently from 6eb4755 to ac73d24 Compare Mar 6, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 6, 2020

Build succeeded.

csomh
csomh approved these changes Mar 6, 2020
Copy link
Member

@csomh csomh left a comment

Nice!

integrations = []

if celery_integration:
# https://docs.sentry.io/platforms/python/celery/
Copy link
Member

@csomh csomh Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs are very well placed. Thanks! 👨‍🎤

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the sentry-integration-for-service branch from ac73d24 to 8d76c5a Compare Mar 6, 2020
@lachmanfrantisek lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label Mar 6, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 6, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 6, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 57745a5 into packit:master Mar 6, 2020
3 checks passed
@lachmanfrantisek lachmanfrantisek deleted the sentry-integration-for-service branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry integrations (update and add new)
3 participants