Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework mapping #476

Merged
merged 3 commits into from Mar 11, 2020
Merged

Rework mapping #476

merged 3 commits into from Mar 11, 2020

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek commented Mar 10, 2020

  • Make the mapping of handlers to events work and easier to use.
    • Testing farm results and Copr events are handled as other events.
    • Mapping support multiple triggers for one job and get's a correct config part.
  • Fixes: copr build for packit repo was not triggered #465

TODO:

  • More tests (more combinations of triggers and configs).
  • Check the commenting.
  • Add docs for the decorators.
  • Remove internal job type (e.g. copr_end) from the JobType enum in packit. (After this PR, it can contain only the config-relevant values.)

@softwarefactory-project-zuul

This comment has been minimized.

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Mar 10, 2020

The commenting part is still WIP -- I need to check/fix all the tests since I've changed the handling of the comment events. (Now, they should be handled in the same way as other events.)

edit: I've reverted that part, it will take some time to make it work.

@softwarefactory-project-zuul

This comment has been minimized.

@lachmanfrantisek lachmanfrantisek changed the title WIP: rework mapping Rework mapping Mar 11, 2020
@lachmanfrantisek lachmanfrantisek added the ready-for-review Pull request is ready for review. label Mar 11, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build succeeded.

Copy link
Member

@TomasTomecek TomasTomecek left a comment

wow, very nice! let's try this on stg

Copy link
Member

@jpopelka jpopelka left a comment

advanced magic level those mappings are :-)

packit_service/worker/jobs.py Show resolved Hide resolved
packit_service/worker/handlers/abstract.py Outdated Show resolved Hide resolved
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label Mar 11, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Mar 11, 2020

recheck

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 11, 2020

Build failed.

@lachmanfrantisek lachmanfrantisek merged commit 1f72cda into packit:master Mar 11, 2020
3 of 5 checks passed
@lachmanfrantisek lachmanfrantisek deleted the mapping branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR. ready-for-review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copr build for packit repo was not triggered
3 participants