Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning users only if deprecated keys are present #754

Merged
merged 2 commits into from Mar 19, 2020

Conversation

shreyaspapi
Copy link
Contributor

@shreyaspapi shreyaspapi commented Mar 9, 2020

Fixes #749 I have added a check to the whole else statement! As it only runs if deprecated keys are present in the raw_dict.

Copy link
Member

@csomh csomh left a comment

See comment on the issue.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 9, 2020

Build succeeded.

@shreyaspapi shreyaspapi force-pushed the issue749 branch 2 times, most recently from 06ad774 to 4ef51a9 Compare Mar 9, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 9, 2020

Build succeeded.

@shreyaspapi shreyaspapi requested a review from csomh Mar 9, 2020
Copy link
Member

@csomh csomh left a comment

Looks good! Would you mind adding some tests, please? 😃

@TomasTomecek
Copy link
Member

TomasTomecek commented Mar 13, 2020

/packit build

@csomh
Copy link
Member

csomh commented Mar 16, 2020

@shreyaspapi reached out today to let me know that he won't be able to continue work on this for 1-2 days.

@shreyaspapi
Copy link
Contributor Author

shreyaspapi commented Mar 18, 2020

Working on it

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build succeeded.

Adding unit test for load_authentication
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 18, 2020

Build succeeded.

@csomh
Copy link
Member

csomh commented Mar 19, 2020

/packit build

csomh
csomh approved these changes Mar 19, 2020
@csomh csomh added the mergeit When set, zuul wil gate and merge the PR. label Mar 19, 2020
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 19, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 93fc81d into packit:master Mar 19, 2020
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants