Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_spec: make it more reliable and readable #759

Conversation

TomasTomecek
Copy link
Member

@TomasTomecek TomasTomecek commented Mar 10, 2020

  • we now rsplit git-describe output which should help when people use
    dashes in tags
  • the code is now shorter and more readable

* we now rsplit git-describe output which should help when people use
  dashes in tags
* the code is now shorter and more readable

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek TomasTomecek added the mergeit When set, zuul wil gate and merge the PR. label Mar 10, 2020
@packit-as-a-service
Copy link

packit-as-a-service bot commented Mar 10, 2020

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-759
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 10, 2020

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 10, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7feb62f into packit:master Mar 10, 2020
10 checks passed
@TomasTomecek TomasTomecek deleted the make-jirka-and-hunor-◕‿◕✿ branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants