Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[srpm] Extend logging of paths and make path to archive explicit #923

Merged
merged 2 commits into from Aug 5, 2020

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Aug 4, 2020

  • logging
    • extends symlinking of path to the linked archive
      also logs relative path to the linked archive
    • prints both relative and absolute path to the created archive
  • has paths that could resolve problem with linking
    Before: archive_in_specdir (links to) created_archive
    Potential solution: created_archive is converted to absolute path and then converted to relative to the specdir

*  logging
   *  extends symlinking of path to the linked archive
      also logs relative path to the linked archive
   *  prints both relative and absolute path to the created archive
*  has paths that could resolve problem with linking
   Before: archive_in_specdir (links to) created_archive
   Potential solution:
     created_archive is converted to absolute path and then converted to
     relative **to the** specdir
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-packit-923
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

*  enforces absolute path to the archive when returning
*  enforces conversion to relative path **to** the specdir
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@mfocko mfocko changed the title Extend logging of paths when creating srpm [srpm] Extend logging of paths and make path to archive explicit Aug 4, 2020
@mfocko mfocko added the ready-for-review Pull request is ready for review. label Aug 4, 2020
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looking good! let's 🚀

@mfocko mfocko added the mergeit When set, zuul wil gate and merge the PR. label Aug 5, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR. ready-for-review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants