New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[srpm] Extend logging of paths and make path to archive explicit #923
Merged
softwarefactory-project-zuul
merged 2 commits into
packit:master
from
mfocko:extend-logging
Aug 5, 2020
Merged
[srpm] Extend logging of paths and make path to archive explicit #923
softwarefactory-project-zuul
merged 2 commits into
packit:master
from
mfocko:extend-logging
Aug 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* logging * extends symlinking of path to the linked archive also logs relative path to the linked archive * prints both relative and absolute path to the created archive * has paths that could resolve problem with linking Before: archive_in_specdir (links to) created_archive Potential solution: created_archive is converted to absolute path and then converted to relative **to the** specdir
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Build succeeded.
|
* enforces absolute path to the archive when returning * enforces conversion to relative path **to** the specdir
Build succeeded.
|
mfocko
changed the title
Extend logging of paths when creating srpm
[srpm] Extend logging of paths and make path to archive explicit
Aug 4, 2020
TomasTomecek
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, looking good! let's 🚀
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mergeit
When set, zuul wil gate and merge the PR.
ready-for-review
Pull request is ready for review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also logs relative path to the linked archive
Before:
archive_in_specdir
(links to)created_archive
Potential solution:
created_archive
is converted to absolute path and then converted to relative to thespecdir