Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for static linking #22
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Hi, thanks for your contribution! Can you make the tests pass, and give me a short tl;dr of what you did? |
This comment has been minimized.
This comment has been minimized.
I've just updated the description with the tl;dr of what it is, and I'll be adding some comments to specific items on why they're there as some of them are non-obvious. On the tests passing:
|
@@ -17,7 +26,7 @@ matrix: | |||
rust: beta | |||
before_install: | | |||
if [ "$TRAVIS_OS_NAME" == "osx" ]; then | |||
brew install unixodbc | |||
HOMEBREW_NO_AUTO_UPDATE=1 brew install unixodbc |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -1,4 +1,5 @@ | |||
sudo: false | |||
dist: bionic |
This comment has been minimized.
This comment has been minimized.
palfrey
Nov 4, 2019
Author
Contributor
Xenial had an older version of unixodbc that didn't support static linking properly.
Great work! |
@@ -17,7 +26,7 @@ matrix: | |||
rust: beta | |||
before_install: | | |||
if [ "$TRAVIS_OS_NAME" == "osx" ]; then | |||
brew install unixodbc | |||
HOMEBREW_NO_AUTO_UPDATE=1 brew install unixodbc |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
palfrey commentedOct 31, 2019
•
edited
Enable support for static linking with the feature flag
static
. This aids the building of single binaries with no system dependencies on systems that support static linking with Rust (e.g. particularly alpine, but theoretically others).