Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Support custom Git service provider #29

Closed
VincentTam opened this issue Jul 4, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@VincentTam
Copy link
Contributor

commented Jul 4, 2019

Feature Request

Due to Staticman v3's native GitLab support introduced in eduardoboucas/staticman#219, it's better to edit this theme's Go-HTML template code to provide support for this. #6 hard codes the :service to github, but this is unnecessarily GitHub specific. Staticman's author says that the app's job is to get the HTML form data into the Git repo in eduardoboucas/staticman#264 (comment). Restricting the form action URL to github contradicts this idea.

<form class="post-new-comment" method="POST" action="https://dev.staticman.net/v3/entry/github/{{ .username }}/{{ .repo }}/{{ .branch }}/data/comments">

See also: mmistakes/minimal-mistakes#1845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.