Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom Staticman endpoint #31

Merged
merged 6 commits into from Jul 5, 2019

Conversation

Projects
None yet
2 participants
@VincentTam
Copy link
Contributor

commented Jul 4, 2019

Description

Fix #28 and close #29.

EDIT: Also closes #21 - PC

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@accesslint
Copy link

left a comment

There are accessibility issues in these changes.

Show resolved Hide resolved layouts/post/staticman.html Outdated
Show resolved Hide resolved layouts/post/staticman.html Outdated

VincentTam added some commits Jul 4, 2019

@accesslint

accesslint bot approved these changes Jul 4, 2019

Copy link

left a comment

👏 You fixed the issue(s)! Great work.

@accesslint
Copy link

left a comment

There are accessibility issues in these changes.

Show resolved Hide resolved layouts/post/staticman.html
@VincentTam
Copy link
Contributor Author

left a comment

Test GitHub's review functionality.

  1. Improved v3 support
  2. Replaced deprecated Hugo syntax
@pacollins

This comment has been minimized.

Copy link
Owner

commented Jul 4, 2019

Man, that is the first time that bot has be used. It is ruthless. Haha, I will review this soon.

@VincentTam

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Perhaps it would be helpful to show GitLab CI's output to verify .UniqueID.File.UniqueID.

@pacollins

This comment has been minimized.

Copy link
Owner

commented Jul 5, 2019

On my end everything works except reCAPTCHA. Is there anything special - is it reCAPTCHA v3?

{"success":false,"message":"reCAPTCHA: The response parameter is invalid or malformed","rawError":{"_smErrorCode":"invalid-input-response"},"errorCode":"RECAPTCHA_INVALID_INPUT_RESPONSE"}

@VincentTam

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Overall speaking, I've not touched your code about reCAPTCHA v3, which I've never tried, so I can't comment. Btw, this PR is meant to be an analogue of mmistakes/minimal-mistakes#1845, and the Go-HTML code in this PR does its work of getting the site config parameters into the generate HTML pages. reCAPTCHA is another issue.

@pacollins

This comment has been minimized.

Copy link
Owner

commented Jul 5, 2019

I see now. I will just need to revert to reCAPTCHA v2.

Thanks for all of this.

@pacollins pacollins merged commit e26d9f3 into pacollins:master Jul 5, 2019

1 check passed

AccessLint Found 1 issue
@VincentTam

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

👍 for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.