Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed config evaluation for include of staticman.js #92

Merged
merged 2 commits into from Sep 7, 2019

Conversation

@th1l6f
Copy link
Contributor

commented Sep 6, 2019

Description

Currently, staticman.js is included/loaded, no matter if staticman is activated or not. In script.html is a check for .Site.Params.staticman which should be .Site.Params.staticman.enabled resp. .Site.Params.staticman.staticman.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@VincentTam
Copy link
Collaborator

left a comment

Nice catch! Thanks for making this PR!

Give a simple explanation for the error observed in a pure Hugo way, consider this example.

# config.yml
#  [params.foo]
#    bar = ""
# Hugo template
{{ .Site.foo }} → false
# config.yml
  [params.foo]
    bar = ""
# Hugo template
{{ .Site.foo }} → true
layouts/partials/scripts.html Outdated Show resolved Hide resolved
@th1l6f

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

I adjusted the indention. I don't bother about that - it's your code.

@VincentTam VincentTam merged commit d788ac7 into pacollins:master Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.