Skip to content

adding azure files for app service deployment#349

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

adding azure files for app service deployment#349
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Sep 26, 2024

Added Bicep file and paramete
added readme
added az cli commands

@YOU54F
Copy link
Member

YOU54F commented Sep 27, 2024

Hey thanks for this.

I think it would be better added to the pact-broker-docker repo, similar to this pull request

https://github.com/pact-foundation/pact-broker-docker/pull/176/files

with the files in an examples subfolder such as example-azure-deployment

https://github.com/pact-foundation/pact-broker-docker/tree/master/example-k8s-deployment

The updated docs will be pulled into this website

https://docs.pact.io/pact_broker/docker_images/pactfoundation#running-on-aws-with-an-alb

@YOU54F YOU54F self-requested a review September 27, 2024 12:45
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets should be moved to https://github.com/pact-foundation/pact-broker-docker along with instructions, that will be pulled into the website via a sync job. 👍🏾

Thanks for the addition however

Repository owner closed this by deleting the head repository Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants