Skip to content

Conversation

@shanehull
Copy link
Contributor

Adds the ability to set additional annotations on the Service resource.

@ChrisJBurns
Copy link
Contributor

Thanks @shanehull I'll try and give this a look so we can get it merged in. I may have to add CI tests into the Actions flow before we do merge this PR though just so we have as much assurance as possible.

@shanehull
Copy link
Contributor Author

@ChrisJBurns let me know if there's anything we can do to get this merged. Currently we're blocked on using the chart, as we need annotations on the Service resource to be able to expose it.

@ChrisJBurns
Copy link
Contributor

@shanehull Yep apologies, just had a chance to go through my unreads. Have approved and run pipeline, and seems to be ok, however are you able to sign the commit?

@shanehull shanehull force-pushed the feat/service-annotations branch from f0b5f03 to 28f6343 Compare September 5, 2024 21:13
@shanehull
Copy link
Contributor Author

Done @ChrisJBurns.

@ChrisJBurns
Copy link
Contributor

@shanehull I don't think the commit itself has been signed, you've added a signature to the commit message but the commit itself isn't signed with a key for more info: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@shanehull shanehull force-pushed the feat/service-annotations branch from 28f6343 to 461e4bc Compare September 5, 2024 23:35
Signed-off-by: shanehull <shane.hull@annalise.ai>
@shanehull shanehull force-pushed the feat/service-annotations branch from 461e4bc to 57fe8c7 Compare September 5, 2024 23:37
@shanehull
Copy link
Contributor Author

Sorry @ChrisJBurns, should be verified now.

@ChrisJBurns ChrisJBurns merged commit 6f2e4e1 into pact-foundation:master Sep 6, 2024
@ChrisJBurns
Copy link
Contributor

Thanks @shanehull , merged!

minedetector pushed a commit to minedetector/pact-broker-chart that referenced this pull request Mar 12, 2025
Signed-off-by: shanehull <shane.hull@annalise.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants