Publisher issues

[tarciosaraiva]

I pulled the code to try and submit a fix but the tests keep failing - even on a clean clone - so I decided to write an issue here.

Issue 1

Under publisher.js on line 99 it uses urlJoin to create a URL to PUT to pact-broker. The issue here is related to data.provider and data.consumer which are both objects. You have to retrieve the actual name by using data.provider.name and data.consumer.name otherwise the URL built will look like

/pacts/provider/[Object%20object]/consumer/[Object%20object]/version/2.0

Issue 2

When there's a failure there's no way to know what happened. On publisher.js line 114 pass back the response object when the promise is rejected.

Thanks

[mboudreau]

@mefellows is this related to the change you did/deployed this morning?

[mefellows]

Looks like it, but not 100% (off the top of my head). There is a unit test associated with it but it's clearly insufficient. I'll investigate this evening if I can.

[tarciosaraiva]

Sorry to be a pain but there's only issue addressed on that commit

On Tue, 21 Jun 2016, 19:11 Matt Fellows notifications@github.com wrote:

Closed #12 #12 via
014cea1
014cea1
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA2h9Lt2M5GGpCmAyfaSrYzZWAB_9UXRks5qN6q1gaJpZM4I6bRU
.

[mefellows]

Issue 1, do you mean?

[tarciosaraiva]

Yup

On Tue, 21 Jun 2016, 19:13 Matt Fellows notifications@github.com wrote:

Issue 1, do you mean?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA2h9CVsa7K0rngx6kqq3-a1qQEQn9cFks5qN6tOgaJpZM4I6bRU
.

[mefellows]

All good, WIP mate :)

[tarciosaraiva]

@mefellows @mboudreau somehow version 4.4.3 didn't get published. Can someone act on it? I have a project here needing this change.

[mboudreau]

@tarciosaraiva The fix branch is building. Waiting to go green before merging and deploying the latest. Keep your pants on ;)

[tarciosaraiva]

I think this is good now. Cheers

[mefellows]

👍