fix: 🐛 avoid node-gyp rebuild install script #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
requested changes
Mar 13, 2024
.DS_Store
Outdated
Member
There was a problem hiding this comment.
could you remove the .DS_Store files and i can give this a merge
Member
|
thanks for the change dude and the investigation. it would be nice to add in the additional context to the pr for posterity |
Add an "install" script in order to "override" npm behavior of adding a "node-gyp rebuild" install script on the fly when publishing
YOU54F
approved these changes
Mar 13, 2024
Contributor
Author
|
The purpose of this change is to prevent npm from adding an "install" script with the value "node-gyp rebuild". This script is added on the fly on the manifest when** the "npm publish" command is executed. This script is not visible in the package.json file published in the tarball. Some registries use the manifest during installation (e.g. Sonatype Nexus), while other registries replace the manifest with the real package.json in order to mitigate the "manifest confusion" vulnerability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an "install" script to "override" npm behavior of adding a "node-gyp rebuild" install script on the fly when publishing.