Feat/optional arch specific binaries - #605
Merged
YOU54F merged 1 commit intoFeb 17, 2025
Merged
Conversation
YOU54F
force-pushed
the
feat/optional_arch_specific_binaries
branch
3 times, most recently
from
January 24, 2025 16:15
10e0f03 to
2ccfe78
Compare
YOU54F
marked this pull request as ready for review
January 24, 2025 22:19
YOU54F
force-pushed
the
feat/optional_arch_specific_binaries
branch
2 times, most recently
from
January 28, 2025 19:02
cb4735d to
0793946
Compare
support libpact_ffi & pact-js-core node bindings to be published in seperate npm packages.
these are segmented by os-arch-libc
users should not need to require these automatically, npm should determine the required
optional dependency to download at install time.
supported_platforms
"@pact-foundation/pact-core-darwin-arm64": "16.0.0",
"@pact-foundation/pact-core-darwin-x64": "16.0.0",
"@pact-foundation/pact-core-linux-arm64-glibc": "16.0.0",
"@pact-foundation/pact-core-linux-arm64-musl": "16.0.0",
"@pact-foundation/pact-core-linux-x64-glibc": "16.0.0",
"@pact-foundation/pact-core-linux-x64-musl": "16.0.0",
"@pact-foundation/pact-core-windows-x64": "16.0.0"
YOU54F
force-pushed
the
feat/optional_arch_specific_binaries
branch
from
January 28, 2025 19:09
0793946 to
809775e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR will fix #602
support libpact_ffi & pact-js-core node bindings to be published in seperate npm packages.
these are segmented by
${os}-{arch}-{libc}users should not need to require these automatically, npm should determine the required
optional dependency to download at install time.
supported_platforms
CI Improvements
Significant build time reductions, by reducing the times when prebuilds are created.
This could be further improved to
nativeor thebindings.gypchangesTesting
Consumed in pact-js, via scoped publish, shown tested in following forked PR
Published for testing
Tested with
See example workflow / simple project
https://github.com/YOU54F/pact-js-packagers-test/blob/main/.github/workflows/test.yml