Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for eachKey and eachValue matchers #1103

Merged
merged 1 commit into from Jul 14, 2023

Conversation

mefellows
Copy link
Member

Fixes #952

@mefellows mefellows force-pushed the fix/eachValue-eachKey-matchers branch from cabc8ac to 5a53dd9 Compare July 13, 2023 11:37
@mefellows mefellows requested a review from YOU54F July 13, 2023 11:38
@mefellows mefellows force-pushed the fix/eachValue-eachKey-matchers branch 4 times, most recently from c5d5d27 to 77f2e3c Compare July 14, 2023 04:37
@mefellows mefellows marked this pull request as ready for review July 14, 2023 07:55
@mefellows mefellows force-pushed the fix/eachValue-eachKey-matchers branch from 77f2e3c to 0b2098b Compare July 14, 2023 07:59
@mefellows mefellows changed the title wip: eachKey and eachValue matchers add support for eachKey and eachValue matchers Jul 14, 2023
@mefellows mefellows changed the title add support for eachKey and eachValue matchers Add support for eachKey and eachValue matchers Jul 14, 2023
@mefellows mefellows merged commit 4c4c839 into master Jul 14, 2023
18 of 26 checks passed
@mefellows mefellows deleted the fix/eachValue-eachKey-matchers branch July 14, 2023 08:00
@TimothyJones
Copy link
Contributor

Deprecates the eachKeyLike matcher, which is broken

This deprecation doesn't appear to be mentioned in the release notes

@mefellows
Copy link
Member Author

Thanks, good spot. I can fix that manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eachKeyLike matcher isn't eachKeyLike, it is eachValueLike (also rust core version needs a bump)
2 participants