fix: mock backend to return the example value provided in date and time v3 matchers#1405
Merged
mefellows merged 1 commit intoApr 1, 2025
Merged
Conversation
Contributor
Author
|
Looks like there's been a discussion on this before - #1076 |
b4f2512 to
95ccccd
Compare
mefellows
approved these changes
Apr 1, 2025
Member
|
Thanks! |
Contributor
Author
|
Thank you @mefellows. From this comment and the commit where the example was made mandatory, it looks like we can make the example input optional. As rust ffi generates example value from the given regex (which probably was not the case then) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run distworks locally (this will run tests, lint and build)PR Template
Currently while using MatchersV3
dateandtime, mock backend returns current date instead of the provided example date.This works correctly for
datetime. So this pr applies similar fix to what was done indatetime(removingpact:generator:typefrom output object when example value is present)Added some tests in pact-reference for this scenario as well - pact-foundation/pact-reference#489