feat: Allow add custom provider headers#627
Conversation
4d1d82f to
cb4b5f5
Compare
Pull Request Test Coverage Report for Build 10694982756Details
💛 - Coveralls |
YOU54F
left a comment
There was a problem hiding this comment.
Looks good,
I would have probably used a different example, rather than introducing a new one with some matcher todos. (Adding the form encoded example, may be better in a sep PR)
Update on docs would be nice - https://github.com/pact-foundation/pact-php/blob/master/docs/provider.md maybe pointing to this
https://docs.pact.io/provider/handling_auth#4-modify-the-request-to-use-real-credentials
Modify Requests Prior to Verification
and borrow some text from pact-js as to the rationale
I don't believe we have request filters as a concept in pact-php for modification of payloads prior to being sent to the provider. I believe JVM and JS do this by starting up a proxy.
cb4b5f5 to
f35048f
Compare
f35048f to
a378890
Compare
|
I added the doc and removed the |
Add ability to add custom provider headers to v10. Somehow I didn't notice this feature is available in v9 and FFI at the same time.