fix: win plugin shutdown#67
Merged
rholshausen merged 5 commits intopact-foundation:mainfrom Jul 5, 2024
Merged
Conversation
YOU54F
force-pushed
the
issue/win_plugin_shutdown
branch
from
823f488 to
8ef58fe
Compare
Member
Author
|
Failing tests due to coming from a fork without creds to publish pacts Have pushed to Windows test times reduced from ~50 mins to ~12 mins |
This was referenced Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows plugins are failing to shutdown which pact-go windows plugin tests to fail
pact-foundation/pact-go#443
it is easily reproducible by installing any plugin, via the latest pact-plugin-cli on windows.
once the plugin is reported as being installed successfully, check the task manager and note a lingering process.
See associated issue and PR :- GuillaumeGomez/sysinfo#257
note,
kill_withhas not been updated to support windows.I've consumed this locally in the pact-go project, and plugins shut down cleanly on windows, and the full test suite has passed