Allow falsy responses (e.g. 0 not as a string). #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you want a regression test as part of this PR. I can try to get to it this week (I haven't stood up a pact dev environment yet, I manually verified this fix with the code I've been using to play with Pact). Thanks for porting pact to python, so far it's really great. |
|
@ftobia Thanks for submitting this PR. That's definitely an issue, and I'm surprised I didn't think of it when I put it together initially, because it would fail for things like empty lists and dicts. I can setup a test for this and get both merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In playing with pact-python I found I was unable to generate a pact file with a body of 0 where the 0 wasn't already a string (e.g. it's a json-encoded response of the number 0). I believe this PR rectifies the issue.