Add Http Post and Delete examples#783
Merged
JP-Ellis merged 2 commits intopact-foundation:masterfrom Sep 25, 2024
Merged
Conversation
Extend the existing examples to showcase both HTTP POST and DELETE requests, and how they are handled in Pact. Specifically showcasing how the verifying can ensure that any side-effects have taken place. Co-authored-by: Amit Singh <amit.828.as@gmail.com> Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
updated-v3-examples-refactored
branch
from
2d9b9a7 to
75edcbb
Compare
Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
updated-v3-examples-refactored
branch
from
fc65cdd to
7c1f341
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage ? 78%
=======================================
Files ? 23
Lines ? 2673
Branches ? 0
=======================================
Hits ? 2111
Misses ? 562
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JP-Ellis
approved these changes
Sep 25, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🚨 Breaking Changes🔥 Motivation
Provide more realistic examples for pact-python
🔨 Test Plan
Examples are inherently tested
🔗 Related issues/PRs
#757