Skip to content

feat: add generate_contents methods#443

Merged
rholshausen merged 1 commit intomasterfrom
feat/generate-contents
Jun 19, 2024
Merged

feat: add generate_contents methods#443
rholshausen merged 1 commit intomasterfrom
feat/generate-contents

Conversation

@JP-Ellis
Copy link
Contributor

The various get_contents FFI method return the raw (unprocessed) contents of the request/response, including all generators and matching rules. The generate_contents alternatives are used to process these generators so that the actual messages as received by the consumer can be retrieved.

@JP-Ellis JP-Ellis requested a review from rholshausen June 19, 2024 00:10
@JP-Ellis JP-Ellis self-assigned this Jun 19, 2024
@JP-Ellis JP-Ellis force-pushed the feat/generate-contents branch from e243ff2 to 8dc9222 Compare June 19, 2024 01:22
@JP-Ellis
Copy link
Contributor Author

Fixed the points you mentioned above.

I'll add a few tests as well to make sure the functions are working as expected.

The various `get_contents` FFI method return the raw (unprocessed)
contents of the request/response, including all generators and matching
rules. The `generate_contents` alternatives are used to process these
generators so that the actual messages as received by the consumer can
be retrieved.

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis force-pushed the feat/generate-contents branch from 8dc9222 to a18b774 Compare June 19, 2024 01:52
@JP-Ellis JP-Ellis marked this pull request as ready for review June 19, 2024 01:52
@JP-Ellis
Copy link
Contributor Author

Tests have now been added.

@rholshausen rholshausen merged commit 3acc9ae into master Jun 19, 2024
@rholshausen rholshausen deleted the feat/generate-contents branch June 19, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants