feat(test):add tests for different date matcher scenarios in pact_ffi#489
Merged
Merged
Conversation
Contributor
|
There is a compile error with the tests: |
Author
|
oops! must have removed the import while reverting lint changes |
72a018a to
11dfc49
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for different
datematcher scenarios (applicable for datetime/time as well) -pact:generator:typeis provided in the body matcher, mock server returns current time (Local::now()) in the provided formatContext - Currently when using pact-js v3 matcher type
dateandtime, mock-server returns current date/time while it's expected to return the example date/time. The issue is not originating from here (will create a seperate pr for that in pact-js), but these additional tests might worth having.