Skip to content

Conversation

@ermul
Copy link
Contributor

@ermul ermul commented May 8, 2024

Overview

This change fixes a couple of bugs exposed by @stan-is-hate in #59 where package namespaces are not taken into account when looking up protobuf messages.

Testing

Ran integrated_tests/imported_message in a loop ~20 times without a failure locally.

@YOU54F
Copy link
Member

YOU54F commented May 9, 2024

Hey thanks @ermul

Can you rebase against main which should resolve the CI failures, expect the Pact Verify job, which is expected to fail on contributor PR's from external repos. (Probably want to add a condition to skip that job in future)

@YOU54F
Copy link
Member

YOU54F commented May 9, 2024

Also thank you for the fix and @stan-is-hate for the investigation 🙌🏾

@ermul ermul force-pushed the package-namespace-fixes branch from 2740f50 to 0f47677 Compare May 9, 2024 16:20
@rholshausen rholshausen merged commit aa28fb4 into pactflow:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants