Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto Module #955

Open
kehiy opened this issue Jan 24, 2024 · 2 comments
Open

Crypto Module #955

kehiy opened this issue Jan 24, 2024 · 2 comments
Labels
dependencies Pull requests that update a dependency file security

Comments

@kehiy
Copy link
Contributor

kehiy commented Jan 24, 2024

Currently, we are using the github.com/kilic/bls12-381 v0.1.0 package for cryptography in Pactus, which is deprecated. we need to update this module and use a new package.

One existing approach is using Rust language for cryptography instead of Golang.
@kehiy kehiy added security high priority It has high priority dependencies Pull requests that update a dependency file labels Jan 24, 2024
@b00f b00f removed the high priority It has high priority label Jan 24, 2024
@b00f
Copy link
Collaborator

b00f commented Jun 11, 2024

The bls12-381 package from the gnark-crypto project looks like a good candidate here: https://pkg.go.dev/github.com/consensys/gnark-crypto/ecc/bls12-381.

@kehiy
Copy link
Contributor Author

kehiy commented Jun 19, 2024 •
edited
Loading

@b00f I agree. between Golang implementations it looks like the most well-maintained one.

Can I work on this refactor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@b00f @kehiy