New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Roster graphs are not shown in the current master in PHP7 #192

Open
khooz opened this Issue Aug 25, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@khooz

khooz commented Aug 25, 2016

Hi,

I have tried nginx1.10s/php70-php-fpm from remi-safe and official nginx repos on a centos 7. The tagged versions wouldn't work
1.5.7: throws "preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead".
1.6.0: empty $priority in Log.php:589 causes Undefined Index notice and breaks;
master: It is working fine but the mini-graphs on Site Roster page does not appear at all. The trend-metrics div is empty and there are no errors in console (just warnings about using wordpress insecure image in my https secure domain)

** update: no graphs are shown at all.
capture2

Hope this gets fixed soon with php7 in mind.
Thanks!

@khooz

This comment has been minimized.

Show comment
Hide comment
@khooz

khooz Aug 27, 2016

Hi,

I have rooted some errors:

  • The one that has lead to Log.php being triggered resides in ./modules/base/classes/paginatedResultSet.php on line 237. There has to be curly bracers now since PHP is treating code resolution funny:
    return $this->$formats[$format](); to return $this->{$formats[$format]}();
  • The one within Log.php itself is that $priority is passed as an empty string. I don't know why yet, but the fix is to set a default value within the function header.

khooz commented Aug 27, 2016

Hi,

I have rooted some errors:

  • The one that has lead to Log.php being triggered resides in ./modules/base/classes/paginatedResultSet.php on line 237. There has to be curly bracers now since PHP is treating code resolution funny:
    return $this->$formats[$format](); to return $this->{$formats[$format]}();
  • The one within Log.php itself is that $priority is passed as an empty string. I don't know why yet, but the fix is to set a default value within the function header.

padams pushed a commit that referenced this issue Dec 18, 2016

Peter Adams
Adding fix for #192.
removing use of old sryle php tags.

padams pushed a commit that referenced this issue Dec 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment