New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 Hour Format for Visit Time Display #293

Open
ryanml opened this Issue Dec 21, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@ryanml

ryanml commented Dec 21, 2017

I couldn't see anything in the configuration for making timestamps display in 12 hour format as opposed to 24.

Personally I prefer 24, but a non technical user of the platform had asked me about this.

If this configuration isn't available, I'd love to take on the feature. It should be pretty straightforward.

From an implementation standpoint, it probably would be best if this was a display only feature at the template level, to avoid breaking any dependencies that count on those stamps being in 24 hour format.

@ryanml

This comment has been minimized.

Show comment
Hide comment
@ryanml

ryanml Dec 21, 2017

For example, when set to display in 12 hour format, this would read:

Wed Dec 20 6:23:06 PM MST

screen shot 2017-12-20 at 7 01 44 pm

ryanml commented Dec 21, 2017

For example, when set to display in 12 hour format, this would read:

Wed Dec 20 6:23:06 PM MST

screen shot 2017-12-20 at 7 01 44 pm

@ryanml

This comment has been minimized.

Show comment
Hide comment
@ryanml

ryanml Dec 28, 2017

@padams what are your thoughts on this? Do you think such a control in the configuration would be beneficial?

ryanml commented Dec 28, 2017

@padams what are your thoughts on this? Do you think such a control in the configuration would be beneficial?

@padams

This comment has been minimized.

Show comment
Hide comment
@padams

padams Dec 28, 2017

Owner

All times are stored in the db as a Unix timestamp (seconds since 1970) so it’s likely being formatted by the view or template that renders that visit feed.

Personally I don’t see a need to add an option for 12 hour formatting but I’d merge a patch if others do.

Owner

padams commented Dec 28, 2017

All times are stored in the db as a Unix timestamp (seconds since 1970) so it’s likely being formatted by the view or template that renders that visit feed.

Personally I don’t see a need to add an option for 12 hour formatting but I’d merge a patch if others do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment