From e4676c3c3faa1cad7f8301d1af799efe8e6ae816 Mon Sep 17 00:00:00 2001 From: "thomas.nisolle-ext" Date: Fri, 4 Feb 2022 17:36:26 +0100 Subject: [PATCH] feat: ESLint migration and lot of fixes --- .eslintrc.json | 97 + .run/lint.run.xml | 16 +- angular.json | 41 +- package-lock.json | 1976 +++++++++++++++-- package.json | 25 +- .../ngx-firestore-repository/.eslintrc.json | 76 + .../ngx-firestore-repository/karma.conf.js | 2 +- .../src/e2e/column.spec.ts | 2 +- .../src/e2e/util/firestore-functions.spec.ts | 2 +- .../e2e/util/repository-intializer.spec.ts | 14 +- .../util/test-firestore-repository.spec.ts | 2 +- .../firestore-repository-builder.service.ts | 2 +- ...eRepository.ts => firestore.repository.ts} | 0 .../firestore-criteria-repository.request.ts | 2 +- ...estore-criteria-request-builder.service.ts | 2 +- ...storeCriteria.ts => firestore.criteria.ts} | 20 +- .../src/public-api.ts | 4 +- projects/ngx-http-repository/.eslintrc.json | 76 + projects/ngx-http-repository/karma.conf.js | 2 +- .../src/e2e/column.spec.ts | 4 +- .../src/e2e/page-response-processor.spec.ts | 15 +- .../src/lib/request/http-request.builder.ts | 2 +- projects/ngx-repository-app/.eslintrc.json | 76 + .../ngx-repository-app/src/app/app.module.ts | 22 +- .../app/component/client/client.component.ts | 2 +- .../libraries/libraries.component.ts | 4 +- .../app/component/person/person.component.ts | 2 - .../processor/my-page-response.processor.ts | 4 +- projects/ngx-repository-app/tslint.json | 17 - projects/ngx-repository/.eslintrc.json | 20 + projects/ngx-repository/karma.conf.js | 2 +- projects/ngx-repository/ng-package.json | 2 +- .../decorator/instance-cache.registry.ts | 4 +- .../resource-type-supports.decorator.spec.ts | 4 - .../lib/core/registry/token.registry.spec.ts | 12 +- .../abstract-repository.builder.spec.ts | 12 +- .../repository/abstract-repository.builder.ts | 2 +- .../core/repository/abstract-repository.ts | 2 +- .../processor/body.response-processor.ts | 3 +- .../processor/page-response.processor.ts | 4 +- .../path-column-response.processor.ts | 3 +- .../processor/void-response.processor.ts | 4 +- .../src/lib/ngx-repository.service.spec.ts | 9 +- .../src/testing/mock.repository.ts | 22 +- .../testing/ngx-repository-testing.module.ts | 2 +- .../src/testing/test-repository.builder.ts | 6 +- tslint.json | 158 -- 47 files changed, 2249 insertions(+), 531 deletions(-) create mode 100644 .eslintrc.json create mode 100644 projects/ngx-firestore-repository/.eslintrc.json rename projects/ngx-firestore-repository/src/lib/repository/{firestoreRepository.ts => firestore.repository.ts} (100%) rename projects/ngx-firestore-repository/src/lib/request/{firestoreCriteria.ts => firestore.criteria.ts} (90%) create mode 100644 projects/ngx-http-repository/.eslintrc.json create mode 100644 projects/ngx-repository-app/.eslintrc.json delete mode 100644 projects/ngx-repository-app/tslint.json create mode 100644 projects/ngx-repository/.eslintrc.json delete mode 100644 tslint.json diff --git a/.eslintrc.json b/.eslintrc.json new file mode 100644 index 0000000..6837a9e --- /dev/null +++ b/.eslintrc.json @@ -0,0 +1,97 @@ +{ + "root": true, + "ignorePatterns": [ + "projects/**/*" + ], + "plugins": [ + "unused-imports" + ], + "rules": { + "no-unused-vars": "off", + "unused-imports/no-unused-imports": "error", + "unused-imports/no-unused-vars": [ + "error", + { "vars": "all", "varsIgnorePattern": "^_", "args": "after-used", "argsIgnorePattern": "^_" } + ], + "prefer-const": "error" + }, + "overrides": [ + { + "files": [ + "*.ts" + ], + "parserOptions": { + "project": [ + "tsconfig.json", + "e2e/tsconfig.json" + ], + "createDefaultProgram": true + }, + "extends": [ + "plugin:@angular-eslint/recommended", + "plugin:@angular-eslint/template/process-inline-templates" + ], + "rules": { + "@angular-eslint/component-selector": [ + "error", + { + "type": "element", + "prefix": "app", + "style": "kebab-case" + } + ], + "@angular-eslint/directive-selector": [ + "error", + { + "type": "attribute", + "prefix": "app", + "style": "camelCase" + } + ], + "quotes": ["error", "single", { "allowTemplateLiterals": true } ], + "semi": ["error", "always"], + "@typescript-eslint/explicit-member-accessibility": [ + "error", + { + "accessibility": "explicit", + "overrides": { + "accessors": "explicit", + "constructors": "explicit" + } + } + ], + "@typescript-eslint/no-empty-interface": "off", + "@typescript-eslint/no-inferrable-types": "off", + "arrow-parens": [ + "off", + "always" + ], + "id-blacklist": "error", + "import/order": "off", + "max-len": [ + "error", + { + "code": 200 + } + ], + "padding-line-between-statements": [ + "error", + { + "blankLine": "always", + "prev": "*", + "next": "return" + } + ] + } + }, + { + "files": [ + "*.html" + ], + "extends": [ + "plugin:@angular-eslint/template/recommended" + ], + "rules": {} + } + ] +} diff --git a/.run/lint.run.xml b/.run/lint.run.xml index 8cc8c52..d2fbf25 100644 --- a/.run/lint.run.xml +++ b/.run/lint.run.xml @@ -1,12 +1,12 @@ - - - + + + -