Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icon on linux when running #123

Open
AdamZ opened this issue Sep 29, 2017 · 6 comments · Fixed by #406
Open

Missing icon on linux when running #123

AdamZ opened this issue Sep 29, 2017 · 6 comments · Fixed by #406
Assignees
Milestone

Comments

@AdamZ
Copy link

AdamZ commented Sep 29, 2017

Super-minor issue. This is on Ubuntu running Gnome 3, with the desktop version of Padlock.

The icon for Padlock appears correctly in the menu, but once the app is running it doesn't seem to have an icon, both on the left hand side of the activities overview (where currently-running apps have icons) and in the alt-tab UI.

padlock_missing_icon

@MaKleSoft MaKleSoft added the bug label Sep 30, 2017
@MaKleSoft
Copy link
Collaborator

@AdamZ Thanks for reporting this! I'll look into it, but right now this has fairly low priority, especially since it looks like it's actually a bug in one of the tools used in the build process and not Padlock itself.

@MaKleSoft
Copy link
Collaborator

@AdamZ Is this still a problem with the latest version?

@AdamZ
Copy link
Author

AdamZ commented Apr 26, 2018

Just checked, and yeah it's still got the same "broken image" icon when it's running. And actually now even in the menu it's just got the generic Electron icon, rather than the padlock one.

@peldax
Copy link

peldax commented Apr 26, 2018

I have the same issue, no icon for running application, plus application menu shows electron icon.

I agree its lowest priority.

@Fr6jDJF
Copy link

Fr6jDJF commented Sep 10, 2018

Same on Linux Mint 19

@BrunoBernardino BrunoBernardino added this to the v4.x milestone Feb 24, 2022
@BrunoBernardino BrunoBernardino self-assigned this Feb 24, 2022
BrunoBernardino added a commit that referenced this issue Feb 24, 2022
I can't build this locally over some strange permissions issue. I'm pushing to try if it works on CI.

I've tried many suggestions mentioned in the following PRs, but nothing worked. This one seems to at least try to do something about the icns file, though it's failing locally, like I said:

- electron-userland/electron-builder#748
- electron-userland/electron-builder#2269
- electron-userland/electron-builder#4617
- electron-userland/electron-builder#5385
- electron-userland/electron-builder#2577 (comment)

Related to #123
@BrunoBernardino
Copy link
Collaborator

This is a problem with the current electron builder. We're looking into ditching Electron and just use Tauri once a few UI issues are sorted anyway, but current solutions didn't work as per #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants