-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHVM Fixes (Take 3 - The Working Version) #274
Conversation
You don't need to create a new pr each time, just push new commits into the brsmch and the pr will be updated |
I want to have them all as separate different pulls so either one can easily be merged at each state. |
👍 for me |
I'll do a take 4 with:
|
@GrahamCampbell honestly don't worry about it! Like I say, it may make it more difficult for others to contribute, it's better to keep it simple. |
Too late now. :P |
Nevermind. Could you just push a note in the README where we explain how to run the tests, just to make it clear to run |
I don't know about anyone else, but I develop on windows, and I have vendor/bin in my PATH. I'll add a notice in the readme about testing... |
I have vendor/bin in my path, but only for directories I whitelist, it can be a bit of a security risk. |
Sure thing. I've updated the contributing guide. How does that look? |
Good enough for me (as you can tell by the spelling and typos, I'm not a hard sell with docs :) Thanks for this. |
Great. :) |
Is this any better?