HHVM Fixes (Take 3 - The Working Version)

[GrahamCampbell]

Is this any better?

[wouterj]

You don't need to create a new pr each time, just push new commits into the brsmch and the pr will be updated

[GrahamCampbell]

I want to have them all as separate different pulls so either one can easily be merged at each state.

[davedevelopment]

👍 for me

[GrahamCampbell]

I'll do a take 4 with:

        "phpunit/phpunit": "4.0.*@dev",
        "phpunit/php-code-coverage": "2.0.*@dev",
        "phpunit/phpunit-mock-objects": "2.0.*@dev"

[davedevelopment]

@GrahamCampbell honestly don't worry about it! Like I say, it may make it more difficult for others to contribute, it's better to keep it simple.

[GrahamCampbell]

Too late now. :P

[davedevelopment]

Nevermind. Could you just push a note in the README where we explain how to run the tests, just to make it clear to run vendor/bin/phpunit and I'll merge this.

[GrahamCampbell]

I don't know about anyone else, but I develop on windows, and I have vendor/bin in my PATH. I'll add a notice in the readme about testing...

[davedevelopment]

I have vendor/bin in my path, but only for directories I whitelist, it can be a bit of a security risk.

[GrahamCampbell]

Sure thing. I've updated the contributing guide. How does that look?

[davedevelopment]

Good enough for me (as you can tell by the spelling and typos, I'm not a hard sell with docs :)

Thanks for this.

[GrahamCampbell]

Great. :)