Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Copyright Headers #276

Merged
merged 1 commit into from
Feb 17, 2014
Merged

Updated Copyright Headers #276

merged 1 commit into from
Feb 17, 2014

Conversation

GrahamCampbell
Copy link
Contributor

Updated for 2010-2014. I've also fixed a few occurrences where a link to the wrong project was included.

@davedevelopment
Copy link
Collaborator

I'm not convinced this is necessary, but it's probably not worth investigating.

davedevelopment added a commit that referenced this pull request Feb 17, 2014
@davedevelopment davedevelopment merged commit 619f304 into mockery:master Feb 17, 2014
@GrahamCampbell
Copy link
Contributor Author

😃

@wouterj
Copy link
Contributor

wouterj commented Feb 17, 2014

only the first publish year is needed

@GrahamCampbell
Copy link
Contributor Author

@wouterj. I've seen both used. It's really personal preference. I can change it to whatever @davedevelopment wants?

@davedevelopment
Copy link
Collaborator

It's done now, no point bikeshedding :)

@aik099
Copy link

aik099 commented Feb 18, 2014

That's why I don't like to put any time-based information (e.g. year) in license code, that is placed in each library's file. For example: https://github.com/aik099/qa-tools/blob/master/library/aik099/QATools/PageObject/How.php

@wouterj
Copy link
Contributor

wouterj commented Feb 18, 2014

@aik099 for a valid copyright notice, you need to include the year of the first release in it.

@aik099
Copy link

aik099 commented Feb 18, 2014

No way, first time I'm hearing about this. A lot of projects on GitHub don't have a year in it. Any reference I can read about it?

@wouterj
Copy link
Contributor

wouterj commented Feb 18, 2014

@GrahamCampbell
Copy link
Contributor Author

Yes, but if you are to look at other popular repos, they don't do this. Take Twitter Bootstrap for example: https://github.com/twbs/bootstrap#copyright-and-license.

@aik099
Copy link

aik099 commented Feb 18, 2014

Yes, but if you are to look at other popular repos, they don't do this. Take Twitter Bootstrap for example:

They do this: https://github.com/twbs/bootstrap/blob/master/js/affix.js

@aik099 http://www.copyright.gov/circs/circ01.pdf page 4

So should I convert @copyright Alexander Obuhovich <aik.bold@gmail.com> into @copyright 2013 Alexander Obuhovich <aik.bold@gmail.com> in each file's DocBlock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants